ptupitsyn commented on code in PR #1616:
URL: https://github.com/apache/ignite-3/pull/1616#discussion_r1094358501
##########
modules/api/src/main/java/org/apache/ignite/sql/ResultSet.java:
##########
@@ -32,7 +32,7 @@
* <p>Note: one and only one of following is possible: {@link #hasRowSet()}
returns {@code true}, or {@link #wasApplied()} returns
* {@code true}, or {@link #affectedRows()} return zero or higher value.
*/
-public interface ResultSet extends Iterator<SqlRow>, AutoCloseable {
+public interface ResultSet<T> extends Iterator<T>, AutoCloseable {
Review Comment:
Done
##########
modules/client/src/test/java/org/apache/ignite/client/fakes/FakeSession.java:
##########
@@ -90,6 +95,23 @@ public CompletableFuture<AsyncResultSet> executeAsync(
return CompletableFuture.completedFuture(new FakeAsyncResultSet(this,
transaction, statement, arguments));
}
+ /** {@inheritDoc} */
+ @Override
+ public <T> CompletableFuture<AsyncResultSet<T>> executeAsync(@Nullable
Transaction transaction, @Nullable Mapper<T> mapper,
+ String query, @Nullable Object... arguments) {
+ return null;
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
