SammyVimes commented on code in PR #1619:
URL: https://github.com/apache/ignite-3/pull/1619#discussion_r1095602783
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/ColumnFamilyUtils.java:
##########
@@ -49,7 +54,7 @@ class ColumnFamilyUtils {
* Utility enum to describe a type of the column family - meta or
partition.
*/
enum ColumnFamilyType {
- META, PARTITION, HASH_INDEX, SORTED_INDEX, UNKNOWN;
+ META, PARTITION, GC_QUEUE, HASH_INDEX, SORTED_INDEX, UNKNOWN;
Review Comment:
We can do this, but we can't use enum name as CF name, because the default
one comes from the RocksDB itself
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/ColumnFamilyUtils.java:
##########
@@ -49,7 +54,7 @@ class ColumnFamilyUtils {
* Utility enum to describe a type of the column family - meta or
partition.
*/
enum ColumnFamilyType {
- META, PARTITION, HASH_INDEX, SORTED_INDEX, UNKNOWN;
+ META, PARTITION, GC_QUEUE, HASH_INDEX, SORTED_INDEX, UNKNOWN;
Review Comment:
We can do the first one, but we can't use enum name as CF name, because the
default one comes from the RocksDB itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
