anton-vinogradov commented on code in PR #10226:
URL: https://github.com/apache/ignite/pull/10226#discussion_r1095578728
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/task/TaskExecutionOptions.java:
##########
@@ -176,13 +176,13 @@ public TaskExecutionOptions asSystemTask() {
}
/** */
- public boolean isAuthenticationDisabled() {
- return isAuthDisabled;
+ public boolean isPublicRequest() {
+ return isPublicReq;
}
/** */
- public TaskExecutionOptions withAuthenticationDisabled() {
- isAuthDisabled = true;
+ public TaskExecutionOptions asPublicRequest() {
Review Comment:
Please fill javadoc explains this option
##########
modules/core/src/main/java/org/apache/ignite/internal/IgniteComputeImpl.java:
##########
@@ -84,20 +85,8 @@ public IgniteComputeImpl() {
* @param ctx Kernal context.
* @param prj Projection.
*/
- public IgniteComputeImpl(GridKernalContext ctx, ClusterGroupAdapter prj) {
- this(ctx, prj, false);
- }
-
- /**
- * @param ctx Kernal context.
- * @param prj Projection.
- * @param async Async support flag.
- */
- private IgniteComputeImpl(GridKernalContext ctx, ClusterGroupAdapter prj,
boolean async) {
- super(async);
-
- this.ctx = ctx;
- this.prj = prj;
+ public IgniteComputeImpl(GridKernalContext ctx, ClusterGroupAdapter prj,
boolean isPublicFacade) {
Review Comment:
Let's replace with some SecurityAwareIgniteComputeImpl extends
IgniteComputeImpl wrapper instead of dedicated constructor.
##########
modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcResultSet.java:
##########
@@ -268,9 +268,10 @@ void closeInternal() throws SQLException {
JdbcConnection conn = (JdbcConnection)stmt.getConnection();
if (conn.isCloseCursorTaskSupported()) {
- Ignite ignite = conn.ignite();
+ IgniteEx ignite = conn.ignite();
-
ignite.compute(ignite.cluster().forNodeId(conn.nodeId())).call(new
JdbcCloseCursorTask(uuid));
+
ignite.internalCompute(ignite.cluster().forNodeId(conn.nodeId()))
+ .call(new JdbcCloseCursorTask(uuid));
Review Comment:
no reason fro newline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
