AMashenkov commented on code in PR #1617:
URL: https://github.com/apache/ignite-3/pull/1617#discussion_r1095728908
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/Inbox.java:
##########
@@ -475,6 +482,7 @@ enum State {
}
private final PriorityQueue<Batch<RowT>> batches = new
PriorityQueue<>(IO_BATCH_CNT);
+ private final AtomicReference<SharedState> sharedStateHolder = new
AtomicReference<>();
Review Comment:
Seems, it just used to exchange value in a single line of code without
implying any atomicity requirement.
Thus it can be replace with plain field, which can be explicitly nullified
in a code with the comment like "we won't send shared state more than once
until next rewind".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
