lowka commented on code in PR #1596:
URL: https://github.com/apache/ignite-3/pull/1596#discussion_r1096960577
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sqllogic/SqlScriptRunner.java:
##########
@@ -244,78 +289,58 @@ boolean ready() throws IOException {
return buffReader.ready();
}
- String positionDescription() {
- return '(' + fileName + ':' + lineNum + ')';
+ ScriptPosition scriptPosition() {
+ return new ScriptPosition(fileName, lineNum);
}
@Override
public void close() throws Exception {
buffReader.close();
}
+ @Nullable
private Command nextCommand() {
Review Comment:
> Les't fix styles and extract static Command classes from SqlScriptRunner
to the top-level classes.
Done + added javadocs and some test cases to _runner/self.test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
