ptupitsyn commented on code in PR #1641: URL: https://github.com/apache/ignite-3/pull/1641#discussion_r1098201963
########## modules/api/src/main/java/org/apache/ignite/tx/TransactionOptions.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.tx; + +/** + * Ignite transaction options. + */ +public class TransactionOptions { + /** Transaction timeout. */ + private long timeoutMillis = 0; + + /** Read-only transaction. */ + private boolean readOnly = false; + + /** + * Returns transaction timeout, in milliseconds. + * + * @return Transaction timeout, in milliseconds. + */ + public long timeoutMillis() { + return timeoutMillis; + } + + /** + * Sets transaction timeout, in milliseconds. + * + * @param timeoutMillis Transaction timeout, in milliseconds. + * @return {@code this} for chaining. + */ + public TransactionOptions timeoutMillis(long timeoutMillis) { + if (readOnly && timeoutMillis != 0) { + throw illegalStateException(); + } + + this.timeoutMillis = timeoutMillis; + + return this; + } + + /** + * Returns a value indicating whether a read-only transaction should be used. + * + * <p>Read-only transactions provide a snapshot view of data at a certain point in time. + * They are lock-free and perform better than normal transactions, but do not permit data modifications. + * + * @return Whether a read-only transaction should be used. + */ + public boolean readOnly() { + return readOnly; + } + + /** + * Sets a value indicating whether a read-only transaction should be used. + * + * <p>Read-only transactions provide a snapshot view of data at a certain point in time. + * They are lock-free and perform better than normal transactions, but do not permit data modifications. + * + * @param readOnly Whether a read-only transaction should be used. + * + * @return {@code this} for chaining. + */ + public TransactionOptions readOnly(boolean readOnly) { + if (readOnly && timeoutMillis != 0) { Review Comment: > call it after the property is set At this point the instance already represents an invalid state. So it is possible to catch the exception, ignore it, and pass invalid options to the tx API. Should we actually move this logic from `TransactionOptions` to the tx API? The user will get an exception either way, but might be easier for us to validate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
