isapego commented on code in PR #1649:
URL: https://github.com/apache/ignite-3/pull/1649#discussion_r1099251275
##########
modules/platforms/cpp/ignite/client/detail/table/table_impl.cpp:
##########
@@ -233,7 +268,7 @@ ignite_tuple read_tuple(protocol::reader &reader, const
schema *sch, const ignit
if (i < sch->key_column_count) {
res.set(column.name, key.get(column.name));
} else {
- res.set(column.name, read_next_column(parser, column.type));
+ res.set(column.name, read_next_column(parser, column.type,
column.scale));
Review Comment:
Roundtrip is checked. I've actually found a bug this way. Compute is not yet
supported in C++. I will add an SQL test - something like `SELECT
CAST('12345.6789' AS DECIMAL(10, 4))`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
