tkalkirill commented on code in PR #1645: URL: https://github.com/apache/ignite-3/pull/1645#discussion_r1099780914
########## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPartitionTimestampCursor.java: ########## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.storage.pagememory.mv; + +import java.util.HashMap; +import java.util.Map; +import java.util.NoSuchElementException; +import org.apache.ignite.internal.hlc.HybridTimestamp; +import org.apache.ignite.internal.pagememory.tree.BplusTree; +import org.apache.ignite.internal.pagememory.tree.BplusTree.TreeRowClosure; +import org.apache.ignite.internal.schema.TableRow; +import org.apache.ignite.internal.storage.PartitionTimestampCursor; +import org.apache.ignite.internal.storage.ReadResult; +import org.apache.ignite.internal.storage.RowId; +import org.apache.ignite.internal.storage.StorageException; +import org.apache.ignite.internal.util.Cursor; +import org.apache.ignite.lang.IgniteInternalCheckedException; +import org.jetbrains.annotations.Nullable; + +abstract class AbstractPartitionTimestampCursor implements PartitionTimestampCursor { + protected final AbstractPageMemoryMvPartitionStorage storage; + + private @Nullable Cursor<VersionChain> versionChainCursor; + + /** {@link ReadResult} obtained by caching {@link VersionChain} with {@link BplusTree#find(Object, Object, TreeRowClosure, Object)}. */ + private final Map<RowId, ReadResult> readResultByRowId = new HashMap<>(); + + private boolean iterationExhausted; + + private @Nullable ReadResult nextRead; + + private @Nullable VersionChain currentChain; + + AbstractPartitionTimestampCursor(AbstractPageMemoryMvPartitionStorage storage) { + this.storage = storage; + } + + @Override + public boolean hasNext() { + return storage.busy(() -> { + storage.throwExceptionIfStorageNotInRunnableState(); + + if (nextRead != null) { + return true; + } + + if (iterationExhausted) { + return false; + } + + createVersionChainCursorIfMissing(); + + currentChain = null; + + while (true) { + if (!versionChainCursor.hasNext()) { + iterationExhausted = true; + + return false; + } + + VersionChain chain = versionChainCursor.next(); + + ReadResult result = readResultByRowId.remove(chain.rowId()); + + if (result == null) { + // TODO: IGNITE-18717 Add lock by rowId + chain = storage.readVersionChain(chain.rowId()); + + if (chain == null) { + continue; + } + + result = findRowVersion(chain); + } + + if (result.isEmpty() && !result.isWriteIntent()) { + continue; + } + + nextRead = result; + currentChain = chain; + + return true; + } + }); + } + + @Override + public final ReadResult next() { + return storage.busy(() -> { + storage.throwExceptionIfStorageNotInRunnableState(); + + if (!hasNext()) { + throw new NoSuchElementException("The cursor is exhausted: " + storage.createStorageInfo()); + } + + assert nextRead != null; + + ReadResult res = nextRead; + + nextRead = null; + + return res; + }); + } + + @Override + public void close() { + if (versionChainCursor != null) { + versionChainCursor.close(); + } + } + + @Override + public @Nullable TableRow committed(HybridTimestamp timestamp) { + return storage.busy(() -> { + storage.throwExceptionIfStorageNotInRunnableState(); + + if (currentChain == null) { + throw new IllegalStateException("Version chain missing: " + storage.createStorageInfo()); + } + + // TODO: IGNITE-18717 Add lock by rowId + VersionChain chain = storage.readVersionChain(currentChain.rowId()); + + if (chain == null) { + return null; + } + + ReadResult result = storage.findRowVersionByTimestamp(chain, timestamp); + + if (result.isEmpty()) { + return null; + } + + // We don't check if row conforms the key filter here, because we've already checked it. + return result.tableRow(); + }); + } + + abstract ReadResult findRowVersion(VersionChain versionChain); Review Comment: I tried to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
