PakhomovAlexander commented on code in PR #1639:
URL: https://github.com/apache/ignite-3/pull/1639#discussion_r1100037728


##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java:
##########
@@ -198,17 +201,26 @@ protected void initChannel(Channel ch) {
                             ch.pipeline().addLast(new IdleChannelHandler());
                         }
 
-                        ch.pipeline().addLast(
-                                new ClientMessageDecoder(),
-                                new ClientInboundMessageHandler(
-                                        igniteTables,
-                                        igniteTransactions,
-                                        queryProcessor,
-                                        configuration,
-                                        igniteCompute,
-                                        clusterService,
-                                        sql,
-                                        clusterId));
+                        if (configuration.ssl().enabled()) {
+                            SslContext sslContext =  
SslContextProvider.forServer(
+                                    configuration.ssl().keyStore(), 
ClientAuth.valueOf(configuration.ssl().clientAuth().toUpperCase())

Review Comment:
   Configuration schema does not allow to do that. 
   
   ```java
       @OneOf({"none", "optional", "require"})
       @Value(hasDefault = true)
       public final String clientAuth = "none";



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to