alievmirza commented on code in PR #1631:
URL: https://github.com/apache/ignite-3/pull/1631#discussion_r1100181911
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -945,21 +984,27 @@ void scheduleTimers(
throw new UnsupportedOperationException("Data nodes auto adjust is
not supported.");
} else {
if (!addedNodes.isEmpty() && autoAdjustScaleUp !=
Integer.MAX_VALUE) {
- //TODO: IGNITE-18121 Create scale up scheduler with
dataNodesAutoAdjustScaleUp timer.
zonesState.get(zoneId).addNodesToDataNodes(addedNodes,
revision);
Review Comment:
renamed
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -1221,16 +1368,56 @@ void removeNodesFromDataNodes(Set<String> nodes, long
revision) {
* @param addition Indicates whether we should accumulate nodes that
should be added to data nodes, or removed.
* @return Accumulated nodes.
*/
- private Set<String> accumulateNodes(long fromKey, long toKey, boolean
addition) {
+ private List<String> accumulateNodes(long fromKey, long toKey, boolean
addition) {
return topologyAugmentationMap.subMap(fromKey, true, toKey,
true).values()
.stream()
.filter(a -> a.addition == addition)
.flatMap(a -> a.nodeNames.stream())
- .collect(toSet());
+ .collect(toList());
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
