kgusakov commented on code in PR #1648:
URL: https://github.com/apache/ignite-3/pull/1648#discussion_r1100240614
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/CliRequests.java:
##########
@@ -187,4 +189,26 @@ public interface LearnersOpResponse extends Message {
Collection<String> newLearnersList();
}
+
+ @Transferable(value =
RaftMessageGroup.RpcClientMessageGroup.SUBSCRIPTION_LEADER_CHANGE_REQUEST)
+ public interface SubscriptionLeaderChangeRequest extends Message {
+ @Marshallable
+ ReplicationGroupId groupId();
+
+ /**
+ * Gets a subscription flag.
+ *
+ * @return True if subscription is started, false when it finished.
+ */
+ boolean subscribe();
+ }
+
+ @Transferable(value =
RpcClientMessageGroup.SUBSCRIPTION_LEADER_CHANGE_RESPONSE_ACKNOWLEDGE)
+ public interface SubscriptionLeaderChangeRequestAcknowledge extends
Message {
+ }
+
+ @Transferable(value =
RpcClientMessageGroup.SUBSCRIPTION_LEADER_CHANGE_RESPONSE)
+ public interface SubscriptionLeaderChangeResponse extends Message {
Review Comment:
Looks like 'LeaderChangeNotification' or smth like this is a better name,
because we can have multiple responses for one request and it is unusual
behaviour for request-response semantic.
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/RaftServiceEventListener.java:
##########
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.raft.server.impl;
+
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.function.Consumer;
+import org.apache.ignite.internal.replicator.ReplicationGroupId;
+import org.apache.ignite.internal.util.CollectionUtils;
+import org.apache.ignite.network.ClusterNode;
+
+/**
+ * RAFT server event listener.
+ */
+public class RaftServiceEventListener {
+ /** Callbacks by group ids. */
+ private ConcurrentHashMap<ReplicationGroupId, Set<Consumer<Long>>>
subscriptions = new ConcurrentHashMap<>();
+
+ /** Callbacks by cluster nodes. */
+ private HashMap<ClusterNode, Set<Consumer<Long>>> nosesSubscriptions = new
HashMap<>();
+
+ /**
+ * Subscribes a node to notification.
+ *
+ * @param groupId Group id.
+ * @param subscriber Subscriber node.
+ * @param notifyAction Notify action.
+ */
+ public void subscribe(ReplicationGroupId groupId, ClusterNode subscriber,
Consumer<Long> notifyAction) {
+ subscriptions.compute(groupId, (id, actions) -> {
+ if (actions == null) {
+ actions = new HashSet<>();
+ }
+
+ actions.add(notifyAction);
+ nosesSubscriptions.computeIfAbsent(subscriber, node -> new
HashSet<>())
+ .add(notifyAction);
+
+ return actions;
+ });
+ }
+
+ /**
+ * Unsubscribes a node.
+ *
+ * @param groupId Group id.
+ * @param clusterNode Subscriber node.
+ */
+ public void unsubscribe(ReplicationGroupId groupId, ClusterNode
clusterNode) {
+ subscriptions.compute(groupId, (id, actions) -> {
+ if (CollectionUtils.nullOrEmpty(actions)) {
+ return null;
+ }
+
+ Set<Consumer<Long>> nodeActions =
nosesSubscriptions.get(clusterNode);
+
+ assert !CollectionUtils.nullOrEmpty(nodeActions);
+
+ Set<Consumer<Long>> grpNodeActions = new HashSet<>(actions);
+
+ grpNodeActions.retainAll(nodeActions);
+
+ assert grpNodeActions.size() == 1 : "Node is not subscribed
[node=" + clusterNode + "groupId=" + groupId + ']';
Review Comment:
Not sure, that I understand the behaviour for the case:
- I'm calling subscribe(group1, clusterNode1, notifyAction1)
- Then I'm calling the same, but with another action: subscribe(group1,
clusterNode1, notifyAction2)
So, as a result I will have subscriptions={group1 -> set(notifyAction1,
notifyAction2)} and nodesSubscriptions={clusterNode1 -> set(notifyAction1,
notifyAction2)). So, here I will have grpNodesActions=set(notifyAction1,
notifyAction2). Is it an issue? Can we have 2 different notifyActions for one
node or not?
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/RaftServiceEventListener.java:
##########
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.raft.server.impl;
+
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.function.Consumer;
+import org.apache.ignite.internal.replicator.ReplicationGroupId;
+import org.apache.ignite.internal.util.CollectionUtils;
+import org.apache.ignite.network.ClusterNode;
+
+/**
+ * RAFT server event listener.
+ */
+public class RaftServiceEventListener {
+ /** Callbacks by group ids. */
+ private ConcurrentHashMap<ReplicationGroupId, Set<Consumer<Long>>>
subscriptions = new ConcurrentHashMap<>();
+
+ /** Callbacks by cluster nodes. */
+ private HashMap<ClusterNode, Set<Consumer<Long>>> nosesSubscriptions = new
HashMap<>();
Review Comment:
no**d**esSubscriptions
##########
modules/raft/build.gradle:
##########
@@ -76,4 +76,8 @@ dependencies {
integrationTestImplementation project(':ignite-raft-api')
integrationTestImplementation libs.jetbrains.annotations
integrationTestImplementation libs.dropwizard.metrics
+
+ compileJava {
+ println "outputDir "
Review Comment:
Debug artifact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
