lowka commented on code in PR #1651:
URL: https://github.com/apache/ignite-3/pull/1651#discussion_r1102564957
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -86,6 +87,23 @@ public void testUnicodeStrings() {
}
}
+ /** Test correctness of char types limitation. */
+ @Test
+ public void charLimitation() {
+ sql("create table limitedChar (pk int primary key, f1 VARCHAR(5), f2
CHAR(4))");
+ assertThrows(CalciteContextException.class, () -> sql("insert into
limitedChar(pk, f2) values (1, 'aaaadddd')"));
+ assertThrows(CalciteContextException.class, () -> sql("insert into
limitedChar values (2, 'aaaaabbbbb', 'aaaadddd')"));
Review Comment:
It would be even better to have a method not only excepts some generic
CalciteContextException but also checks for error message.
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -86,6 +87,23 @@ public void testUnicodeStrings() {
}
}
+ /** Test correctness of char types limitation. */
+ @Test
+ public void charLimitation() {
+ sql("create table limitedChar (pk int primary key, f1 VARCHAR(5), f2
CHAR(4))");
+ assertThrows(CalciteContextException.class, () -> sql("insert into
limitedChar(pk, f2) values (1, 'aaaadddd')"));
+ assertThrows(CalciteContextException.class, () -> sql("insert into
limitedChar values (2, 'aaaaabbbbb', 'aaaadddd')"));
Review Comment:
It would be even better to have a method that not only excepts some generic
CalciteContextException but also checks for error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
