Pochatkin commented on code in PR #1640:
URL: https://github.com/apache/ignite-3/pull/1640#discussion_r1104142463
##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/configuration/ItConfigCommandTest.java:
##########
@@ -67,6 +67,31 @@ void addConfigKeyValue() {
);
}
+ @Test
+ @DisplayName("Should update config with hocon format when valid
cluster-endpoint-url is given")
+ void addNodeConfigKeyValue() {
+ // When update default data storage to rocksdb
+ execute("node", "config", "update", "--node-url", NODE_URL,
+ "network.nodeFinder.netClusterNodes : [ \"localhost:3344\",
\"localhost:3345\" ]");
+
+ // Then
+ assertAll(
+ this::assertExitCodeIsZero,
+ this::assertErrOutputIsEmpty,
+ this::assertOutputIsNotEmpty
+ );
+
+ // When read the updated cluster configuration
+ execute("node", "config", "show", "--node-url", NODE_URL);
+
+ // Then
+ assertAll(
+ this::assertExitCodeIsZero,
+ this::assertErrOutputIsEmpty,
+ () -> assertOutputContains("\"netClusterNodes\" : [
\"localhost:3344\", \"localhost:3345\" ]")
Review Comment:
We use JSON format in REST responses, please take a look into
org.apache.ignite.internal.rest.configuration.NodeConfigurationController and
org.apache.ignite.internal.configuration.rest.presentation.hocon.HoconPresentation#representByPath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
