lowka commented on code in PR #1623:
URL: https://github.com/apache/ignite-3/pull/1623#discussion_r1104304161
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java:
##########
@@ -287,7 +294,11 @@ public static Object fromInternal(ExecutionContext<?>
ectx, Object val, Type sto
return Period.of((Integer) val / 12, (Integer) val % 12, 0);
} else if (storageType == byte[].class && val instanceof ByteString) {
return ((ByteString) val).getBytes();
+ } else if (storageType == UUID.class) {
Review Comment:
It is not sufficient because else branch is called for all other type/value
combinations.
And if guard for UUID tests that a value of UUID data type is UUID and
nothing else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
