tkalkirill commented on code in PR #1652: URL: https://github.com/apache/ignite-3/pull/1652#discussion_r1105633197
########## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AddWriteInvokeClosure.java: ########## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.storage.pagememory.mv; + +import static org.apache.ignite.internal.pagememory.util.PageIdUtils.NULL_LINK; +import static org.apache.ignite.internal.storage.pagememory.mv.AbstractPageMemoryMvPartitionStorage.ALWAYS_LOAD_VALUE; +import static org.apache.ignite.internal.storage.pagememory.mv.AbstractPageMemoryMvPartitionStorage.rowBytes; + +import java.nio.ByteBuffer; +import java.util.UUID; +import org.apache.ignite.internal.pagememory.tree.BplusTree; +import org.apache.ignite.internal.pagememory.tree.IgniteTree.InvokeClosure; +import org.apache.ignite.internal.pagememory.tree.IgniteTree.OperationType; +import org.apache.ignite.internal.schema.BinaryRow; +import org.apache.ignite.internal.storage.MvPartitionStorage; +import org.apache.ignite.internal.storage.RowId; +import org.apache.ignite.internal.storage.StorageException; +import org.apache.ignite.internal.storage.TxIdMismatchException; +import org.apache.ignite.lang.IgniteInternalCheckedException; +import org.jetbrains.annotations.Nullable; + +/** + * Implementation of {@link InvokeClosure} for {@link AbstractPageMemoryMvPartitionStorage#addWrite(RowId, BinaryRow, UUID, UUID, int)}. + * + * <p>Synchronization between reading and updating the version chain occurs due to the locks (read and write) of the page of the tree on + * which the version chain is located. + * + * <p>Synchronization between update operations for the version chain must be external (by {@link RowId row ID}). + * + * <p>Operation may throw {@link StorageException} and {@link TxIdMismatchException} which will cause form + * {@link BplusTree#invoke(Object, Object, InvokeClosure)}. + */ +class AddWriteInvokeClosure implements InvokeClosure<VersionChain> { + private final RowId rowId; + + private final @Nullable BinaryRow row; + + private final UUID txId; + + private final UUID commitTableId; + + private final int commitPartitionId; + + private final AbstractPageMemoryMvPartitionStorage storage; + + private @Nullable VersionChain newRow; + + private @Nullable BinaryRow previousUncommittedRowVersion; + + private @Nullable RowVersion toRemove; + + AddWriteInvokeClosure( + RowId rowId, + @Nullable BinaryRow row, + UUID txId, + UUID commitTableId, + int commitPartitionId, + AbstractPageMemoryMvPartitionStorage storage + ) { + this.rowId = rowId; + this.row = row; + this.txId = txId; + this.commitTableId = commitTableId; + this.commitPartitionId = commitPartitionId; + this.storage = storage; + } + + @Override + public void call(@Nullable VersionChain oldRow) throws IgniteInternalCheckedException { + if (oldRow == null) { + RowVersion newVersion = insertRowVersion(row, NULL_LINK); + + newRow = VersionChain.createUncommitted(rowId, txId, commitTableId, commitPartitionId, newVersion.link(), NULL_LINK); + + return; + } + + if (oldRow.isUncommitted()) { + throwIfChainBelongsToAnotherTx(oldRow, txId); + } + + RowVersion newVersion = insertRowVersion(row, oldRow.newestCommittedLink()); + + if (oldRow.isUncommitted()) { + RowVersion currentVersion = storage.readRowVersion(oldRow.headLink(), ALWAYS_LOAD_VALUE); + + previousUncommittedRowVersion = storage.rowVersionToBinaryRow(currentVersion); + + // As we replace an uncommitted version with new one, we need to remove old uncommitted version. + toRemove = currentVersion; + } + + newRow = VersionChain.createUncommitted(rowId, txId, commitTableId, commitPartitionId, newVersion.link(), newVersion.nextLink()); + } + + @Override + public @Nullable VersionChain newRow() { + assert newRow != null; + + return newRow; + } + + @Override + public OperationType operationType() { + return OperationType.PUT; + } + + @Override + public void onUpdate() { + if (toRemove != null) { + storage.removeRowVersion(toRemove); Review Comment: I agree, I'll fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
