petrov-mg commented on code in PR #10473:
URL: https://github.com/apache/ignite/pull/10473#discussion_r1106793161
##########
modules/core/src/main/java/org/apache/ignite/IgniteJdbcDriver.java:
##########
@@ -130,139 +123,9 @@
* <p> Defaults to {@code false}, meaning that the whole result set is
fetched to memory eagerly.
* </li>
* </ul>
- *
Review Comment:
The javadoc above still mentions Java Client Based driver
`* JDBC driver can return two different types of connection: Ignite Java
client based connection`
Let's remove it.
##########
modules/core/src/main/java/org/apache/ignite/IgniteJdbcDriver.java:
##########
@@ -436,27 +296,20 @@ public class IgniteJdbcDriver implements Driver {
if (!parseUrl(url, props))
throw new SQLException("URL is invalid: " + url);
- if (url.startsWith(URL_PREFIX)) {
- if (props.getProperty(PROP_CFG) != null)
- LOG.warning(PROP_CFG + " property is not applicable for this
URL.");
-
- return new JdbcConnection(url, props);
- }
- else
- return new org.apache.ignite.internal.jdbc2.JdbcConnection(url,
props);
+ return new org.apache.ignite.internal.jdbc2.JdbcConnection(url, props);
Review Comment:
Now we can get rid of the package name.
##########
modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcResultSetSelfTest.java:
##########
@@ -1128,4 +1131,65 @@ private TestObjectField(int a, String b) {
return S.toString(TestObjectField.class, this);
}
}
+
Review Comment:
Let's fix the codestyle here and below. At the very least, we should remove
the mention of non-existent classes from the javadoc.
##########
modules/core/src/main/resources/META-INF/classnames.properties:
##########
@@ -403,8 +403,6 @@ org.apache.ignite.internal.events.DiscoveryCustomEvent
org.apache.ignite.internal.executor.GridExecutorService
org.apache.ignite.internal.executor.GridExecutorService$1
org.apache.ignite.internal.executor.GridExecutorService$TaskTerminateListener
-org.apache.ignite.internal.jdbc.JdbcConnectionValidationTask
-org.apache.ignite.internal.jdbc.JdbcConnectionValidationTask$1
Review Comment:
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcMetadataTask`
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcMetadataTask$JdbcDriverMetadataJob`
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcTask`
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcTask$JdbcDriverJob`
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcTask$JdbcDriverJob$1`
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcValidationTask`
Should be removed as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
