sashapolo commented on code in PR #1665:
URL: https://github.com/apache/ignite-3/pull/1665#discussion_r1106865366
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/registry/SchemaRegistryImpl.java:
##########
@@ -118,7 +118,8 @@ public SchemaDescriptor schema(int ver) {
/** {@inheritDoc} */
@Override
public SchemaDescriptor waitLatestSchema() {
- int lastVer0 = latestVersionStore.getAsInt();
+ // TODO: remove blocking code
https://issues.apache.org/jira/browse/IGNITE-17931
+ int lastVer0 = latestVersionStore.get().join();
Review Comment:
I agree that this is kind of a pointless solution. But I think it is still
useful, because blocking code is now in one place, so, when this class is
refactored (under a different ticket), we can remove all these blocking calls
at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
