ibessonov commented on code in PR #1679:
URL: https://github.com/apache/ignite-3/pull/1679#discussion_r1107200012
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -594,21 +595,33 @@ private void sendClusterState(CmgRaftService raftService,
ClusterNode node) {
}
private void sendClusterState(CmgRaftService raftService,
Collection<ClusterNode> nodes) {
- raftService.readClusterState()
- .thenAccept(state -> {
- // Raft state might not have been initialized in case of
leader failure during cluster init
- // TODO: properly handle this case, see
https://issues.apache.org/jira/browse/IGNITE-16819
- if (state == null) {
- throw new IllegalStateException("Cluster state is
empty");
+ raftService.logicalTopology()
+ .thenCompose(topology -> {
+ // Only send the ClusterStateMessage to nodes not already
present in the Logical Topology.
Review Comment:
But why? I don't understand the situation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
