lowka commented on code in PR #1623:
URL: https://github.com/apache/ignite-3/pull/1623#discussion_r1107262472
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/LeastRestrictiveTypesTest.java:
##########
@@ -208,14 +215,37 @@ private static Stream<Arguments> bigIntTests() {
return tests.stream();
}
+ @ParameterizedTest
+ @MethodSource("uuidTests")
+ public void testUuid(RelDataType t1, RelDataType t2, LeastRestrictiveType
leastRestrictiveType) {
+ expectLeastRestrictiveType(t1, t2, leastRestrictiveType);
+ expectLeastRestrictiveType(t2, t1, leastRestrictiveType);
+ }
+
+ private static Stream<Arguments> uuidTests() {
+ List<Arguments> tests = new ArrayList<>();
+
+ tests.add(Arguments.arguments(UUID, TINYINT, new
LeastRestrictiveType(ANY)));
+ tests.add(Arguments.arguments(UUID, SMALLINT, new
LeastRestrictiveType(ANY)));
+ tests.add(Arguments.arguments(UUID, INTEGER, new
LeastRestrictiveType(ANY)));
+ tests.add(Arguments.arguments(UUID, FLOAT, new
LeastRestrictiveType(ANY)));
+ tests.add(Arguments.arguments(UUID, REAL, new
LeastRestrictiveType(ANY)));
+ tests.add(Arguments.arguments(UUID, DOUBLE, new
LeastRestrictiveType(ANY)));
+ tests.add(Arguments.arguments(UUID, DECIMAL, new
LeastRestrictiveType(ANY)));
+ tests.add(Arguments.arguments(UUID, BIGINT, new
LeastRestrictiveType(ANY)));
+ tests.add(Arguments.arguments(UUID, VARCHAR, new
LeastRestrictiveType(UUID)));
Review Comment:
Created a separate issue for that because it seems that doing so brakes some
internal calcite invariants. (the same as for IgniteCustomType::getFamily)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
