AMashenkov commented on code in PR #1680:
URL: https://github.com/apache/ignite-3/pull/1680#discussion_r1108578025
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/ssl/ItSslTest.java:
##########
@@ -233,9 +286,12 @@ class ClusterWithSslAndClientAuth {
+ " type: JKS,"
+ " password: \"" + password + "\","
+ " path: \"" + trustStorePath + "\""
- + " },\n"
+ + " }\n"
+ " }\n"
+ "}";
+ @WorkDirectory
Review Comment:
```suggestion
@WorkDirectory
```
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/ssl/ItSslTest.java:
##########
@@ -143,6 +178,9 @@ class ClusterWithSsl {
+ " }\n"
+ " }\n"
+ "}";
+ @WorkDirectory
Review Comment:
```suggestion
@WorkDirectory
```
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/ssl/ItSslTest.java:
##########
@@ -79,6 +75,9 @@ class ClusterWithoutSsl {
+ " }\n"
+ " }\n"
+ "}";
+ @WorkDirectory
Review Comment:
```suggestion
@WorkDirectory
```
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/ssl/ItSslTest.java:
##########
@@ -305,5 +338,23 @@ void clientCanConnectWithSslAndClientAuth() throws
Exception {
assertThat(client.clusterNodes(), hasSize(2));
}
}
+
+ @Test
+ @DisplayName("Jdbc client can connect with SSL configured")
+ void jdbcCanConnectWithSslAndClientAuth() throws SQLException {
+ var url =
+ "jdbc:ignite:thin://127.0.0.1:10800"
+ + "?sslEnabled=true"
+ + "&trustStorePath=" + trustStorePath
+ + "&trustStoreType=JKS"
+ + "&trustStorePassword=" + password
+ + "&clientAuth=require"
Review Comment:
Ok, we check only connectivity here.
I think we can create a ticket to add more tests later, to check supported
cyphers and clientAuth option, and maybe smth else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
