Pochatkin commented on code in PR #1690:
URL: https://github.com/apache/ignite-3/pull/1690#discussion_r1111611591
##########
modules/rest/src/main/java/org/apache/ignite/internal/rest/RestComponent.java:
##########
@@ -214,12 +217,18 @@ private int
mapServerStartupException(ServerStartupException exception) {
private Map<String, Object> properties(int port, int sslPort) {
boolean dualProtocol = restConfiguration.dualProtocol().value();
boolean sslEnabled = restConfiguration.ssl().enabled().value();
+ ClientAuth clientAuth =
ClientAuth.valueOf(restConfiguration.ssl().clientAuth().value().toUpperCase());
Review Comment:
Any ssl configuration value providers are null safety? If yes, I think it
should be explained here or add null checks. Moreover this configuration read
should be under if (sslEnabled) check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
