tkalkirill commented on code in PR #1699:
URL: https://github.com/apache/ignite-3/pull/1699#discussion_r1113005650
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestMvPartitionStorage.java:
##########
@@ -611,7 +610,7 @@ void abortRebalance() {
groupConfig = null;
}
- void finishRebalance(long lastAppliedIndex, long lastAppliedTerm,
RaftGroupConfiguration raftGroupConfig) {
+ void finishRebalance(long lastAppliedIndex, long lastAppliedTerm, byte[]
raftGroupConfig) {
Review Comment:
maybe rename `raftGroupConfig` -> `groupConfig`
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java:
##########
@@ -383,7 +382,7 @@ public CompletableFuture<Void> finishRebalancePartition(
int partitionId,
long lastAppliedIndex,
long lastAppliedTerm,
- RaftGroupConfiguration raftGroupConfig
+ byte[] raftGroupConfig
Review Comment:
maybe rename `raftGroupConfig` -> `groupConfig`
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java:
##########
@@ -332,10 +329,14 @@ public void
committedGroupConfiguration(RaftGroupConfiguration config) {
});
}
- private void saveRaftGroupConfiguration(AbstractWriteBatch writeBatch,
RaftGroupConfiguration config) throws RocksDBException {
- writeBatch.put(meta, lastGroupConfigKey, ByteUtils.toBytes(config));
+ private void saveRaftGroupConfiguration(AbstractWriteBatch writeBatch,
byte[] config) throws RocksDBException {
Review Comment:
maybe rename `raftGroupConfig` -> `groupConfig`
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##########
@@ -751,7 +750,7 @@ public CompletableFuture<Void> finishRebalancePartition(
int partitionId,
long lastAppliedIndex,
long lastAppliedTerm,
- RaftGroupConfiguration raftGroupConfig
+ byte[] raftGroupConfig
Review Comment:
maybe rename `raftGroupConfig` -> `groupConfig`
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java:
##########
@@ -1480,7 +1477,7 @@ void abortRebalance(WriteBatch writeBatch) {
*
* @throws StorageRebalanceException If there was an error when finishing
the rebalance.
*/
- void finishRebalance(WriteBatch writeBatch, long lastAppliedIndex, long
lastAppliedTerm, RaftGroupConfiguration raftGroupConfig) {
+ void finishRebalance(WriteBatch writeBatch, long lastAppliedIndex, long
lastAppliedTerm, byte[] raftGroupConfig) {
Review Comment:
maybe rename `raftGroupConfig` -> `groupConfig`
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestMvPartitionStorage.java:
##########
@@ -620,7 +619,7 @@ void finishRebalance(long lastAppliedIndex, long
lastAppliedTerm, RaftGroupConfi
this.lastAppliedIndex = lastAppliedIndex;
this.lastAppliedTerm = lastAppliedTerm;
- this.groupConfig = raftGroupConfig;
+ this.groupConfig = Arrays.copyOf(raftGroupConfig,
raftGroupConfig.length);
Review Comment:
maybe rename `raftGroupConfig` -> `groupConfig`
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestMvTableStorage.java:
##########
@@ -313,7 +312,7 @@ public CompletableFuture<Void> finishRebalancePartition(
int partitionId,
long lastAppliedIndex,
long lastAppliedTerm,
- RaftGroupConfiguration raftGroupConfig
+ byte[] raftGroupConfig
Review Comment:
maybe rename `raftGroupConfig` -> `groupConfig`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
