Flaugh24 commented on code in PR #1569: URL: https://github.com/apache/ignite-3/pull/1569#discussion_r1113341741
########## modules/rest/src/test/java/org/apache/ignite/internal/rest/auth/TestAuthSubscriber.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.rest.auth; + +import io.micronaut.security.authentication.AuthenticationResponse; +import org.jetbrains.annotations.Nullable; +import org.reactivestreams.Subscriber; +import org.reactivestreams.Subscription; + +/** Implementation of {@link Subscriber} for tests. */ +public class TestAuthSubscriber implements Subscriber<AuthenticationResponse> { + private Subscription source; + private @Nullable AuthenticationResponse lastResponse; + private @Nullable Throwable lastError; + + @Override + public void onSubscribe(Subscription subscription) { + source = subscription; + source.request(1); + } + + @Override + public void onNext(AuthenticationResponse authenticationResponse) { + lastResponse = authenticationResponse; + } + + @Override + public void onError(Throwable throwable) { + lastError = throwable; + } + + @Override + public void onComplete() { + source.cancel(); + } + + public void reset() { Review Comment: removed the method ########## modules/runner/src/integrationTest/java/org/apache/ignite/internal/rest/RestNode.java: ########## @@ -15,30 +15,34 @@ * limitations under the License. */ -package org.apache.ignite.internal.rest.ssl; +package org.apache.ignite.internal.rest; import java.nio.file.Path; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.Ignite; import org.apache.ignite.IgnitionManager; +import org.apache.ignite.internal.rest.ssl.ItRestSslTest; /** Presentation of Ignite node for tests. */ public class RestNode { - /** Key store path. */ - private static final String keyStorePath = "ssl/keystore.p12"; - - /** Key store password. */ - private static final String keyStorePassword = "changeit"; - + private final String keyStorePath; + private final String keyStorePassword; private final Path workDir; private final String name; private final int networkPort; private final int httpPort; private final int httpsPort; private final boolean sslEnabled; private final boolean dualProtocol; + private CompletableFuture<Ignite> igniteNodeFuture; + + Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
