AMashenkov commented on code in PR #1629:
URL: https://github.com/apache/ignite-3/pull/1629#discussion_r1114953863
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortNode.java:
##########
@@ -38,16 +43,45 @@
/** Rows buffer. */
private final PriorityQueue<RowT> rows;
+ /** SQL select limit. Negative if disabled. */
+ private final int limit;
+
+ /** Reverse-ordered rows in case of limited sort. */
+ private List<RowT> reversed;
Review Comment:
```suggestion
/** Reverse-ordered rows in case of limited sort. */
private List<RowT> stack;
```
Also, I'd use fastutil Stack interface here, or even add Stack backed by
ArrayList to core module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
