ptupitsyn commented on code in PR #1698: URL: https://github.com/apache/ignite-3/pull/1698#discussion_r1115582056
########## modules/api/src/main/java/org/apache/ignite/deployment/DeploymentUnit.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.deployment; + +import java.io.InputStream; + +/** + * Deployment unit interface. + */ +public interface DeploymentUnit { + Review Comment: ```suggestion ``` ########## modules/api/src/main/java/org/apache/ignite/deployment/UnitStatus.java: ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.deployment; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Set; +import org.apache.ignite.deployment.version.Version; +import org.apache.ignite.internal.tostring.S; + +/** + * Deployment unit status. + */ +public class UnitStatus { + /** + * Unit identifier. + */ + private final String id; + + /** + * Map from existing unit version to list of nodes consistent ids where unit deployed. + */ + private final Map<Version, List<String>> versionToConsistentIds; + + private UnitStatus(String id, Map<Version, List<String>> versionToConsistentIds) { + this.id = id; + this.versionToConsistentIds = Collections.unmodifiableMap(versionToConsistentIds); + } + + public String id() { + return id; + } + + public Set<Version> versions() { + return Collections.unmodifiableSet(versionToConsistentIds.keySet()); + } + + public List<String> consistentIds(Version version) { + return Collections.unmodifiableList(versionToConsistentIds.get(version)); + } + + /** + * Builder provider. + * + * @param id Identifier of unit. Not null and not blank. + * @return Instance of {@link UnitStatusBuilder}. + */ + public static UnitStatusBuilder builder(String id) { + Objects.requireNonNull(id); + + return new UnitStatusBuilder(id); + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + UnitStatus that = (UnitStatus) o; + return Objects.equals(id, that.id) && Objects.equals(versionToConsistentIds, that.versionToConsistentIds); + } + + @Override + public int hashCode() { + return Objects.hash(id, versionToConsistentIds); + } + + @Override + public String toString() { + return S.toString(this); + } Review Comment: Missing inheritdoc ########## modules/api/src/main/java/org/apache/ignite/deployment/version/UnitVersion.java: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.deployment.version; + +/** + * Implementation of {@link Version} interface based on the three numbers format, + * like x.x.x. where x is short number. + */ +public class UnitVersion implements Version { + private final short major; + private final short minor; + private final short patch; + + /** + * Constructor. + * + * @param major Major part of version. + * @param minor Minor part of version. + * @param patch Patch part of version. + */ + public UnitVersion(short major, short minor, short patch) { + this.major = major; + this.minor = minor; + this.patch = patch; + } + + @Override + public String render() { + return major + "." + minor + "." + patch; + } + + /** + * Parse string representation of version to {@link UnitVersion} if possible. + * + * @param s String representation of version. + * @return Instance of {@link UnitVersion}. + * @throws VersionParseException in case when string is not required {@link UnitVersion} format. + */ + public static UnitVersion parse(String s) { + try { + String[] split = s.split("\\.", -1); + if (split.length > 3 || split.length == 0) { + throw new VersionParseException("Invalid version format"); + } + + short major = Short.parseShort(split[0]); + short minor = split.length > 1 ? Short.parseShort(split[1]) : 0; + short patch = split.length > 2 ? Short.parseShort(split[2]) : 0; + + return new UnitVersion(major, minor, patch); + } catch (NumberFormatException e) { + throw new VersionParseException(e); + } + } + + @Override Review Comment: Missing javadoc/inheritdoc here and below ########## modules/client/src/main/java/org/apache/ignite/internal/client/TcpIgniteClient.java: ########## @@ -139,6 +140,11 @@ public IgniteCompute compute() { return compute; } + @Override Review Comment: Missing inheritdoc ########## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/exception/DeploymentUnitNotExistException.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.deployunit.exception; + +import org.apache.ignite.lang.ErrorGroups.CodeDeployment; +import org.apache.ignite.lang.IgniteException; + +/** + * Throws when trying to access information about unit which doesn't exist. + */ +public class DeploymentUnitNotExistException extends IgniteException { + Review Comment: ```suggestion ``` ########## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/configuration/DeploymentConfigurationSchema.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.deployunit.configuration; + +import org.apache.ignite.configuration.annotation.ConfigurationRoot; +import org.apache.ignite.configuration.annotation.ConfigurationType; +import org.apache.ignite.configuration.annotation.Value; + +/** + * Configuration schema for Compute functionality. + */ +@ConfigurationRoot(rootName = "deployment", type = ConfigurationType.LOCAL) +public class DeploymentConfigurationSchema { + Review Comment: ```suggestion ``` ########## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/exception/UndeployNotExistedDeploymentUnitException.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.deployunit.exception; + +import org.apache.ignite.lang.ErrorGroups.CodeDeployment; +import org.apache.ignite.lang.IgniteException; + +/** + * Throws when trying to undeploy not existed unit. + */ +public class UndeployNotExistedDeploymentUnitException extends IgniteException { + Review Comment: ```suggestion ``` ########## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/exception/DeploymentUnitReadException.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.deployunit.exception; + +import org.apache.ignite.lang.ErrorGroups.CodeDeployment; +import org.apache.ignite.lang.IgniteException; + +/** + * Throws when deployment unit content failed to read. + */ +public class DeploymentUnitReadException extends IgniteException { + Review Comment: ```suggestion ``` ########## modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java: ########## @@ -390,4 +390,45 @@ public static class NodeConfiguration { */ public static final int CONFIG_WRITE_ERR = NODE_CONFIGURATION_ERR_GROUP.registerErrorCode(3); } + + /** + * Code deployment error group. + */ + public static class CodeDeployment { + /** + * Code deployment error group. + */ + public static final ErrorGroup CODE_DEPLOYMENT_ERR_GROUP = ErrorGroup.newGroup("CODEDEPLOY", 13); + + /** + * Config read error. + */ + public static final int UNDEPLOY_NOT_EXISTED_ERR = CODE_DEPLOYMENT_ERR_GROUP.registerErrorCode(1); + + /** + * Unit duplicate error. + */ + public static final int DUPLICATE_DEPLOY_UNIT_ERR = CODE_DEPLOYMENT_ERR_GROUP.registerErrorCode(2); + + /** + * Access to not existed deployment unit. + */ + public static final int NOT_EXISTED_UNIT_ERR = CODE_DEPLOYMENT_ERR_GROUP.registerErrorCode(3); + + /** + * Deployment unit content read error. + */ + public static final int UNIT_CONTENT_READ_ERR = CODE_DEPLOYMENT_ERR_GROUP.registerErrorCode(4); + + /** + * Deployment unit meta data write error. + */ + public static final int UNIT_META_WRITE_ERR = CODE_DEPLOYMENT_ERR_GROUP.registerErrorCode(5); + + /** + * Deployment unit invalid identifier error. + */ + public static final int UNIT_INVALID_IDENTIFIER_ERR = CODE_DEPLOYMENT_ERR_GROUP.registerErrorCode(6); + Review Comment: ```suggestion ``` ########## modules/api/src/main/java/org/apache/ignite/deployment/UnitStatus.java: ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.deployment; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Set; +import org.apache.ignite.deployment.version.Version; +import org.apache.ignite.internal.tostring.S; + +/** + * Deployment unit status. + */ +public class UnitStatus { + /** + * Unit identifier. + */ + private final String id; + + /** + * Map from existing unit version to list of nodes consistent ids where unit deployed. + */ + private final Map<Version, List<String>> versionToConsistentIds; + + private UnitStatus(String id, Map<Version, List<String>> versionToConsistentIds) { + this.id = id; + this.versionToConsistentIds = Collections.unmodifiableMap(versionToConsistentIds); + } + + public String id() { + return id; + } + + public Set<Version> versions() { + return Collections.unmodifiableSet(versionToConsistentIds.keySet()); + } + + public List<String> consistentIds(Version version) { + return Collections.unmodifiableList(versionToConsistentIds.get(version)); + } + + /** + * Builder provider. + * + * @param id Identifier of unit. Not null and not blank. + * @return Instance of {@link UnitStatusBuilder}. + */ + public static UnitStatusBuilder builder(String id) { + Objects.requireNonNull(id); + + return new UnitStatusBuilder(id); + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + UnitStatus that = (UnitStatus) o; + return Objects.equals(id, that.id) && Objects.equals(versionToConsistentIds, that.versionToConsistentIds); + } + + @Override + public int hashCode() { + return Objects.hash(id, versionToConsistentIds); + } + + @Override + public String toString() { + return S.toString(this); + } + + /** + * Builder for {@link UnitStatus}. + */ + public static class UnitStatusBuilder { + + private final String id; + private final Map<Version, List<String>> versionToConsistentIds = new HashMap<>(); + + public UnitStatusBuilder(String id) { + this.id = id; + } + + public UnitStatusBuilder append(Version version, List<String> consistentIds) { + versionToConsistentIds.put(version, consistentIds); + return this; + } + + public UnitStatus build() { + return new UnitStatus(id, versionToConsistentIds); + } Review Comment: Missing javadoc on public API ########## modules/api/src/main/java/org/apache/ignite/deployment/version/UnitVersion.java: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.deployment.version; + +/** + * Implementation of {@link Version} interface based on the three numbers format, + * like x.x.x. where x is short number. + */ +public class UnitVersion implements Version { + private final short major; + private final short minor; + private final short patch; + + /** + * Constructor. + * + * @param major Major part of version. + * @param minor Minor part of version. + * @param patch Patch part of version. + */ + public UnitVersion(short major, short minor, short patch) { + this.major = major; + this.minor = minor; + this.patch = patch; + } + + @Override Review Comment: Missing javadoc ########## modules/api/src/main/java/org/apache/ignite/deployment/UnitStatus.java: ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.deployment; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Set; +import org.apache.ignite.deployment.version.Version; +import org.apache.ignite.internal.tostring.S; + +/** + * Deployment unit status. + */ +public class UnitStatus { + /** + * Unit identifier. + */ + private final String id; + + /** + * Map from existing unit version to list of nodes consistent ids where unit deployed. + */ + private final Map<Version, List<String>> versionToConsistentIds; + + private UnitStatus(String id, Map<Version, List<String>> versionToConsistentIds) { + this.id = id; + this.versionToConsistentIds = Collections.unmodifiableMap(versionToConsistentIds); + } + + public String id() { + return id; + } + + public Set<Version> versions() { + return Collections.unmodifiableSet(versionToConsistentIds.keySet()); + } + + public List<String> consistentIds(Version version) { + return Collections.unmodifiableList(versionToConsistentIds.get(version)); + } Review Comment: Missing javadoc on public API ########## modules/api/src/main/java/org/apache/ignite/deployment/version/VersionParseException.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.deployment.version; + +/** + * Throws when {@link Version} of deployment unit not parsable. + */ +public class VersionParseException extends RuntimeException { + Review Comment: ```suggestion ``` ########## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/exception/DeploymentUnitIdentifierException.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.deployunit.exception; + +import static org.apache.ignite.lang.ErrorGroups.CodeDeployment.UNIT_INVALID_IDENTIFIER_ERR; + +import org.apache.ignite.lang.IgniteException; + +/** + * Throws when deployment unit have invalid identifier or version. + */ +public class DeploymentUnitIdentifierException extends IgniteException { + Review Comment: ```suggestion ``` ########## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/exception/DuplicateDeploymentUnitException.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.deployunit.exception; + +import org.apache.ignite.lang.ErrorGroups.CodeDeployment; +import org.apache.ignite.lang.IgniteException; + +/** + * Throws when trying to deploy unit which already exist. + */ +public class DuplicateDeploymentUnitException extends IgniteException { + Review Comment: ```suggestion ``` ########## modules/api/src/test/java/org/apache/ignite/deployment/version/VersionUnitTest.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.deployment.version; + +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.is; + +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +/** + * Unit tests for {@link Version}. + */ +public class VersionUnitTest { + Review Comment: ```suggestion ``` ########## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/exception/DeployUnitWriteMetaException.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.deployunit.exception; + +import org.apache.ignite.lang.ErrorGroups.CodeDeployment; +import org.apache.ignite.lang.IgniteException; + +/** + * Throws when unit meta information failed to write. + */ +public class DeployUnitWriteMetaException extends IgniteException { + Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
