PakhomovAlexander commented on code in PR #1710:
URL: https://github.com/apache/ignite-3/pull/1710#discussion_r1116001293
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/logger/CliLoggers.java:
##########
@@ -59,6 +61,10 @@ public static IgniteLogger forName(String name) {
return Loggers.forName(name, loggerFactory);
}
+ public static void addApiClient(ApiClient client) {
+ httpLoggers.add(new HttpLogging(client));
Review Comment:
`HttpLogging` does not define `equals` and `hashCode`. So, I think the
method `addApiClient ` is not idempotent. I suppose we will add client loggers
each time we create a client. Could you confirm that using `--verbose` flag
does not duplicate the HTTP logging in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
