Flaugh24 commented on code in PR #1569:
URL: https://github.com/apache/ignite-3/pull/1569#discussion_r1116652506
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/rest/ClusterManagementController.java:
##########
@@ -70,8 +85,14 @@ public CompletableFuture<Void> init(@Body InitCommand
initCommand) {
LOG.info("Received init command [metaStorageNodes={},
cmgNodes={}]", initCommand.metaStorageNodes(),
initCommand.cmgNodes());
}
-
- return clusterInitializer.initCluster(initCommand.metaStorageNodes(),
initCommand.cmgNodes(), initCommand.clusterName())
+ AuthConfigDto authConfigDto = initCommand.authConfig();
+ RestAuthConfig restAuthConfig = authConfigDto == null ? disabledAuth()
: authConfigDtoToRestAuthConfig(authConfigDto);
Review Comment:
I don't think we have to make users fill authConfigDto if they don't want to
enable authentication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
