ibessonov commented on code in PR #1722:
URL: https://github.com/apache/ignite-3/pull/1722#discussion_r1119780530
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java:
##########
@@ -974,6 +975,24 @@ public void testCfgGap() throws InterruptedException {
checkTableWithData(newNode, "t2");
}
+ /**
+ * The test for updating cluster configuration with the default value.
+ * Check that new nodes will be able to synchronize the local cluster
configuration.
+ */
+ @Test
+ public void updateClusterCfgWithDefaultValue() {
+ IgniteImpl ignite = startNode(0);
+
+ RocksDbStorageEngineConfiguration dbStorageEngineConfiguration =
ignite.clusterConfiguration()
+ .getConfiguration(RocksDbStorageEngineConfiguration.KEY);
+ int defaultValue =
dbStorageEngineConfiguration.flushDelayMillis().value();
+
dbStorageEngineConfiguration.flushDelayMillis().update(defaultValue).join();
Review Comment:
Can you please add timeout to the join?
Another question - why have you decided to write an integration test instead
of the unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
