timoninmaxim commented on code in PR #10453:
URL: https://github.com/apache/ignite/pull/10453#discussion_r1121345467


##########
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java:
##########
@@ -529,6 +531,11 @@ public ClientConfiguration 
setTransactionConfiguration(ClientTransactionConfigur
     }
 
     /**
+     * Partition awareness functionality helps to avoid an additional network 
hop in the following scenarios:
+     * 1. Single-key operations API, like put(), get(), etc. However, the 
functionality has no effect on those operations

Review Comment:
   You should mark javadoc correctly. There are 2 examples:
   1. Bad - check the javadocs for IndexQuery, it uses new line for splitting 
points and it doesn't work. 
   2. Good example - GridEncryptionManager, it uses tags "li", "ul", and it 
works.
   
   The difference of you can check here - 
https://javadoc.io/doc/org.apache.ignite/ignite-core/2.14.0/index.html. 
Unfortunately it's impossible to provide direct links to the classes javadocs, 
but you can easily find them in a class list.
   



##########
docs/_docs/thin-clients/java-thin-client.adoc:
##########
@@ -79,6 +79,12 @@ Note that the code above provides a failover mechanism in 
case of server node fa
 
 include::includes/partition-awareness.adoc[]
 
+Partition awareness functionality helps to avoid an additional network hop in 
the following scenarios:
+
+1. Single-key operations API, like put(), get(), etc. However, the 
functionality has no effect on those operations within explicit transactions 
(initiated via ClientTransaction.txStart() described in <<Transactions>> 
section).
+
+2. ScanQuery and IndexQuery accept a partition number as a parameter with 
which the query is routed to a particular server node that stores the requested 
data. Refer to <<Executing Scan Queries>> and 
link:key-value-api/using-cache-queries[Executing Index Queries] sections for 
more information.

Review Comment:
   link:key-value-api/using-cache-queries**#executing-index-queries**



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to