tkalkirill commented on code in PR #1720:
URL: https://github.com/apache/ignite-3/pull/1720#discussion_r1122138509
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1246,12 +1279,16 @@ private void dropTableLocally(long causalityToken,
String name, UUID tblId, List
try {
int partitions = assignment.size();
+ CompletableFuture<?>[] removeStorageFromGcFutures = new
CompletableFuture<?>[partitions];
+
for (int p = 0; p < partitions; p++) {
TablePartitionId replicationGroupId = new
TablePartitionId(tblId, p);
raftMgr.stopRaftNodes(replicationGroupId);
replicaMgr.stopReplica(replicationGroupId);
+
+ removeStorageFromGcFutures[p] =
mvGc.removeStorage(replicationGroupId);
Review Comment:
Yes, we do it below in the method, see variable `CompletableFuture<Void>
destroyTableStoragesFuture`.
I think the order is correct, at the beginning we stop the raft, then we
remove the table from the gc, then we destroy the tables.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1246,12 +1279,16 @@ private void dropTableLocally(long causalityToken,
String name, UUID tblId, List
try {
int partitions = assignment.size();
+ CompletableFuture<?>[] removeStorageFromGcFutures = new
CompletableFuture<?>[partitions];
+
for (int p = 0; p < partitions; p++) {
TablePartitionId replicationGroupId = new
TablePartitionId(tblId, p);
raftMgr.stopRaftNodes(replicationGroupId);
replicaMgr.stopReplica(replicationGroupId);
+
+ removeStorageFromGcFutures[p] =
mvGc.removeStorage(replicationGroupId);
Review Comment:
Yes, we do it below in the method, see variable `CompletableFuture<Void>
destroyTableStoragesFuture`.
I think the order is correct, at the beginning we stop the raft, then we
remove the table from the gc, then we destroy the tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
