lowka commented on code in PR #1734:
URL: https://github.com/apache/ignite-3/pull/1734#discussion_r1122758650
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteMethod.java:
##########
@@ -94,7 +95,10 @@ public enum IgniteMethod {
GREATEST2(IgniteSqlFunctions.class, "greatest2", Object.class,
Object.class),
/** See {@link Objects#equals(Object, Object)}. */
- IS_NOT_DISTINCT_FROM(Objects.class, "equals", Object.class, Object.class);
+ IS_NOT_DISTINCT_FROM(Objects.class, "equals", Object.class, Object.class),
+
+ /** See {@link UUID#randomUUID()}. */
+ RAND_UUID(UUID.class, "randomUUID");
Review Comment:
I think it would be better to name this function RANDOM_UUID, because
abbreviations are mostly used in cases when a function is borrowed from an
existing domain (such as math, finance, etc) and that name is widely adopted
(so the name is defacto standard).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
