rpuch commented on code in PR #1569: URL: https://github.com/apache/ignite-3/pull/1569#discussion_r1122985043
########## modules/security/build.gradle: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +plugins { + alias(libs.plugins.shadow) +} + +apply from: "$rootDir/buildscripts/java-core.gradle" +apply from: "$rootDir/buildscripts/publishing.gradle" +apply from: "$rootDir/buildscripts/java-junit5.gradle" +apply from: "$rootDir/buildscripts/java-test-fixtures.gradle" + +description = 'ignite-security' + +dependencies { + implementation project(path: ':ignite-core') + annotationProcessor project(':ignite-configuration-annotation-processor') + + implementation project(':ignite-api') + implementation project(':ignite-core') + implementation project(':ignite-configuration') + implementation libs.jetbrains.annotations + implementation libs.auto.service.annotations + + annotationProcessor libs.auto.service + + testImplementation project(':ignite-configuration') + testImplementation(testFixtures(project(':ignite-configuration'))) + testImplementation libs.mockito.core + testImplementation libs.hamcrest.core + testImplementation libs.hamcrest.optional + + testFixturesImplementation project(':ignite-configuration') + testFixturesImplementation libs.jetbrains.annotations + +} + +compileJava { + options.fork = true + options.forkOptions.jvmArgs += '-Dmicronaut.openapi.config.file=openapi/openapi.properties' +} + +shadowJar { + archiveAppendix.set('shaded') + archiveClassifier.set('shaded') + + minimize() + + relocate('reactor', 'reactor.shaded') Review Comment: So we still shadow reactor-core here? Does this apply to all reactor-core dependencies we use (including the one brought by scalecube)? ########## modules/rest/build.gradle: ########## @@ -59,22 +56,33 @@ dependencies { testImplementation project(':ignite-configuration') testImplementation(testFixtures(project(':ignite-core'))) testImplementation(testFixtures(project(':ignite-configuration'))) + testImplementation(testFixtures(project(':ignite-security'))) testImplementation libs.slf4j.jdk14 + testImplementation libs.micronaut.junit5 + testImplementation libs.micronaut.http.client testImplementation libs.mockito.core testImplementation libs.hamcrest.core testImplementation libs.hamcrest.optional + + integrationTestAnnotationProcessor libs.micronaut.inject.annotation.processor + integrationTestAnnotationProcessor testFixtures(project(':ignite-core')) + integrationTestAnnotationProcessor testFixtures(project(':ignite-cluster-management')) + + integrationTestImplementation project(':ignite-rest-api') + integrationTestImplementation project(':ignite-network') + integrationTestImplementation project(':ignite-api') + integrationTestImplementation project(':ignite-security') + integrationTestImplementation testFixtures(project(':ignite-core')) + integrationTestImplementation testFixtures(project(':ignite-cluster-management')) + integrationTestImplementation testFixtures(project(':ignite-configuration')) + integrationTestImplementation libs.micronaut.junit5 + integrationTestImplementation libs.micronaut.test + integrationTestImplementation libs.micronaut.http.client + integrationTestImplementation libs.micronaut.http.server.netty + integrationTestImplementation libs.typesafe.config } compileJava { options.fork = true options.forkOptions.jvmArgs += '-Dmicronaut.openapi.config.file=openapi/openapi.properties' } - -shadowJar { Review Comment: Should we still leave a TODO to a ticket about shadowing reactor-core later? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
