korlov42 commented on code in PR #1756:
URL: https://github.com/apache/ignite-3/pull/1756#discussion_r1127527965
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionContext.java:
##########
@@ -221,28 +213,6 @@ public ClusterNode localNode() {
return localNode;
}
- /**
- * Returns the function to compute colocation hash for specified table.
- *
- * @param tableId An identifier of a table. This identifier will be used
to acquire expected types
- * of the colocation fields.
- * @param fields Indexes of the fields representing colocation columns.
This is a projection of
- * the colocation fields of specified table on actual row. For
example, type of the row to insert
- * equals to the type of table's row, thus passed fields should match
the colocation columns of the table.
- * But row for delete may contain the primary fields only, thus we
need to project colocation fields
- * on this trimmed row.
- * @return A hash function.
- */
- // this is more like workaround to limit scope of the refactoring,
- // but it definitely need to be fixed
- // TODO: https://issues.apache.org/jira/browse/IGNITE-18900
- public RowHashFunction<RowT> hashFunction(UUID tableId, int[] fields) {
- return hashFunctionCache.computeIfAbsent(
- new HashFunctionCacheKey(tableId, fields),
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
