korlov42 commented on code in PR #1754:
URL: https://github.com/apache/ignite-3/pull/1754#discussion_r1128061317
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -322,6 +328,8 @@ private void onMessage(String nodeName, QueryStartRequest
msg) {
assert nodeName != null && msg != null;
DistributedQueryManager queryManager =
queryManagerMap.computeIfAbsent(msg.queryId(), key -> {
+ sqlSchemaManager.waitActualSchema(msg.lastVersion());
Review Comment:
I'm afraid this is not very god idea to block inside update closure, because
you are basically blocking even those queries which don't require latest
schema. Moreover, it's possible to avoid thread blocking at all: we need to
schedule the task after required schema will be available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
