ygerzhedovich commented on code in PR #1675:
URL: https://github.com/apache/ignite-3/pull/1675#discussion_r1129410264
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractAggregatePlannerTest.java:
##########
@@ -493,56 +493,26 @@ static void ensureAllCasesAreCovered() {
}
/**
- * Validates SUM aggregate has a correct return type for any numeric
column type.
- */
- @Test
- public void sumAggregateTypes() throws Exception {
- List<RelDataType> types0 = List.of(
-
TYPE_FACTORY.createTypeWithNullability(TYPE_FACTORY.createSqlType(SqlTypeName.BIGINT),
true),
-
TYPE_FACTORY.createTypeWithNullability(TYPE_FACTORY.createSqlType(SqlTypeName.BIGINT),
true),
-
TYPE_FACTORY.createTypeWithNullability(TYPE_FACTORY.createSqlType(SqlTypeName.BIGINT),
true),
-
TYPE_FACTORY.createTypeWithNullability(TYPE_FACTORY.createSqlType(SqlTypeName.DECIMAL,
- TYPE_FACTORY.getTypeSystem().getMaxNumericPrecision(),
0), true),
-
TYPE_FACTORY.createTypeWithNullability(TYPE_FACTORY.createSqlType(SqlTypeName.DECIMAL,
- TYPE_FACTORY.getTypeSystem().getMaxNumericPrecision(),
DecimalNativeType.DEFAULT_SCALE), true),
-
TYPE_FACTORY.createTypeWithNullability(TYPE_FACTORY.createSqlType(SqlTypeName.DOUBLE),
true),
-
TYPE_FACTORY.createTypeWithNullability(TYPE_FACTORY.createSqlType(SqlTypeName.DOUBLE),
true));
-
- Predicate<RelNode> pred = nodeOrAnyChild(isInstanceOf(SingleRel.class))
- .and(n -> {
- List<RelDataType> types =
n.getRowType().getFieldList().stream()
- .map(RelDataTypeField::getType)
- .collect(Collectors.toList());
-
- return types.equals(types0);
- });
-
- assertPlan(TestCase.CASE_22, pred);
- assertPlan(TestCase.CASE_22A, pred);
- }
-
- /**
- * Rules to disable.
+ * Verifies given test case with provided predicate.
+ *
+ * <p>That is, applies predicate to the result of the query optimization
with regards to the
+ * provided collection of rules which have to be disabled during
optimization.
*
- * @return Rules.
+ * @param testCase A test case tp verify.
Review Comment:
what is `tp`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
