zstan commented on code in PR #1754:
URL: https://github.com/apache/ignite-3/pull/1754#discussion_r1130595772


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -322,6 +328,8 @@ private void onMessage(String nodeName, QueryStartRequest 
msg) {
         assert nodeName != null && msg != null;
 
         DistributedQueryManager queryManager = 
queryManagerMap.computeIfAbsent(msg.queryId(), key -> {
+            sqlSchemaManager.waitActualSchema(msg.lastVersion());

Review Comment:
   If i correctly understand you, such approach is not working for now, or i 
miss you idea ? 
   
   `
           CompletableFuture<SchemaPlus> fut = 
sqlSchemaManager.waitActualSchema(msg.lastVersion());
   
           fut.thenApply((sch) -> {
               DistributedQueryManager queryManager = 
queryManagerMap.computeIfAbsent(msg.queryId(), key -> {
                   BaseQueryContext ctx = createQueryContext(key, msg.schema(), 
msg.parameters());
   
                   return new DistributedQueryManager(ctx);
               });
   
               return queryManager;
           }).whenComplete((mgr, e) -> mgr.submitFragment(nodeName, msg.root(), 
msg.fragmentDescription(), msg.txAttributes()));
   `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to