alex-plekhanov commented on code in PR #10576:
URL: https://github.com/apache/ignite/pull/10576#discussion_r1130813897
##########
modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/Command.java:
##########
@@ -124,14 +124,34 @@ public default void usage(
CommandList cmd,
@Nullable Map<String, String> paramsDesc,
String... args
+ ) {
+ usage(logger, desc, cmd.text(), paramsDesc, args);
+ }
+
+ /**
+ * Print command usage.
+ *
+ * @param logger Logger to use.
+ * @param desc Command description.
+ * @param cmd Command.
+ * @param paramsDesc Description of parameters (optional).
+ * @param args Arguments.
+ */
+ public default void usage(
+ IgniteLogger logger,
+ String desc,
+ String cmd,
+ @Nullable Map<String, String> paramsDesc,
+ String... args
) {
logger.info("");
if (experimental())
logger.info(INDENT + "[EXPERIMENTAL]");
logger.info(INDENT + desc);
- logger.info(DOUBLE_INDENT + CommandLogger.join(" ", UTILITY_NAME, cmd,
CommandLogger.join(" ", args)));
+ logger.info(DOUBLE_INDENT + CommandLogger.join(" ", UTILITY_NAME, cmd,
Review Comment:
Reverted
##########
modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/CommandArgIterator.java:
##########
@@ -45,9 +49,14 @@ public class CommandArgIterator {
* @param argsIt Raw argument iterator.
* @param commonArgumentsAndHighLevelCommandSet All known subcomands.
*/
- public CommandArgIterator(Iterator<String> argsIt, Set<String>
commonArgumentsAndHighLevelCommandSet) {
+ public CommandArgIterator(
+ Iterator<String> argsIt,
+ Set<String> commonArgumentsAndHighLevelCommandSet,
+ Map<String, Command<?>> cmds
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
