sashapolo commented on code in PR #1748:
URL: https://github.com/apache/ignite-3/pull/1748#discussion_r1132206430
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java:
##########
@@ -588,6 +599,10 @@ private CompletableFuture<Void>
changeInternally0(ConfigurationSource src, long
throw new ConfigurationValidationException(validationIssues);
}
+ // "allChanges" map can be empty here in case the given update
matches the current state of the local configuration. We
+ // still try to write the empty update, because local
configuration can be obsolete. If this is the case, then the CAS will
+ // fail and the update will be recalculated and there is a chance
that the new local configuration will produce an non-empty
Review Comment:
yes, you are correct, this is a typo from my side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
