tkalkirill commented on code in PR #1781:
URL: https://github.com/apache/ignite-3/pull/1781#discussion_r1133590545
##########
modules/configuration-annotation-processor/src/main/java/org/apache/ignite/internal/configuration/processor/ConfigurationProcessor.java:
##########
@@ -256,6 +256,10 @@ private boolean process0(RoundEnvironment
roundEnvironment) {
createRootKeyField(configInterface,
configurationInterfaceBuilder, schemaClassName, clazz);
}
+ configurationInterfaceBuilder.addMethod(
Review Comment:
Please give an example in the comments how the code will look like.
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/NamedListConfiguration.java:
##########
@@ -97,6 +97,13 @@ public T get(String name) {
return config == null ? null : (T) config.specificConfigTree();
}
+ @Override
+ public T get(UUID internalId) {
Review Comment:
```suggestion
public @Nullable T get(UUID internalId) {
```
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/asm/DirectProxyAsmGenerator.java:
##########
@@ -164,6 +167,19 @@ private void addConstructor() {
.ret();
}
+ /**
+ * Generates {@link DirectPropertyProxy#directProxy()} method
implementation.
Review Comment:
Please give an example in the comments how the code will look like.
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/direct/DirectNamedListProxy.java:
##########
@@ -64,19 +64,12 @@ public DirectNamedListProxy(
return creator.apply(appendKey(keys, new KeyPathNode(name, true)),
changer);
}
- /**
- * Retrieves a named list element by its internal id.
- *
- * @param internalId Internal id.
- * @return Named list element, associated with the passed internal id, or
{@code null} if it doesn't exist.
- */
- public T getByInternalId(UUID internalId) {
+ @Override
+ public T get(UUID internalId) {
Review Comment:
```suggestion
public @Nullable T get(UUID internalId) {
```
##########
modules/configuration-api/src/main/java/org/apache/ignite/configuration/NamedConfigurationTree.java:
##########
@@ -36,6 +38,19 @@
*/
@Nullable T get(String name);
+ /**
+ * Retrieves a named list element by its internal id.
+ *
+ * @param internalId Internal id.
+ * @return Named list element, associated with the passed internal id, or
{@code null} if it doesn't exist.
+ */
+ T get(UUID internalId);
Review Comment:
```suggestion
@Nullable T get(UUID internalId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
