AMashenkov commented on code in PR #1754:
URL: https://github.com/apache/ignite-3/pull/1754#discussion_r1133650541
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -321,13 +320,22 @@ private AsyncCursor<List<Object>>
executeExplain(ExplainPlan plan) {
private void onMessage(String nodeName, QueryStartRequest msg) {
assert nodeName != null && msg != null;
- DistributedQueryManager queryManager =
queryManagerMap.computeIfAbsent(msg.queryId(), key -> {
- BaseQueryContext ctx = createQueryContext(key, msg.schema(),
msg.parameters());
+ CompletableFuture<?> fut =
sqlSchemaManager.waitActualSchema(msg.lastVersion());
- return new DistributedQueryManager(ctx);
- });
+ fut.whenComplete((mgr, e) -> {
+ if (e != null) {
+ LOG.error("Schema operation error", e);
Review Comment:
I think there should be a guarantee that QueryStartResponse will be sent
back in case of error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
