sanpwc commented on code in PR #1797:
URL: https://github.com/apache/ignite-3/pull/1797#discussion_r1139881721
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -873,25 +873,25 @@ private void initDataNodesFromVaultManager() {
try {
if (vaultEntry != null && vaultEntry.value() !=
null) {
logicalTopology =
fromBytes(vaultEntry.value());
+ }
- // init keys and data nodes for default zone
- saveDataNodesAndUpdateTriggerKeysInMetaStorage(
- DEFAULT_ZONE_ID,
- appliedRevision,
- logicalTopology
- );
+ // init keys and data nodes for default zone
+ saveDataNodesAndUpdateTriggerKeysInMetaStorage(
+ DEFAULT_ZONE_ID,
+ appliedRevision,
+ logicalTopology
Review Comment:
Well, the easiest way will be to catch NPE and ignore it. What I wan't to
say here is that easier doesn't mean better.
Besides that, we'll need to fix immediate dataNodes recalculation and
postpone it according to scaleUp/Down values, so that proposed approach won't
work at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
