ibessonov commented on code in PR #1780:
URL: https://github.com/apache/ignite-3/pull/1780#discussion_r1142081924
##########
modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeploymentManagerImpl.java:
##########
@@ -139,7 +139,7 @@ public DeploymentManagerImpl(ClusterService clusterService,
this.metaStorage = metaStorage;
this.configuration = configuration;
this.cmgManager = cmgManager;
- deploymentChannelInfo = ChannelInfo.generate("DeploymentUnits");
+ deploymentChannelType = ChannelType.register((short) 1,
"DeploymentUnits");
Review Comment:
I'm not trying to be rude, but how does it even work? As far as I remember,
there's a static map inside of there.
This means, that by starting 2 Ignite nodes, you'll try to register 2
channel types with identical ids. This will fail with exception, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
