ygerzhedovich commented on code in PR #1732:
URL: https://github.com/apache/ignite-3/pull/1732#discussion_r1142094541
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java:
##########
@@ -272,18 +254,10 @@ private void checkIntegerLimit(SqlNode n, String
nodeName) {
} else if (n instanceof SqlDynamicParam) {
SqlDynamicParam dynamicParam = (SqlDynamicParam) n;
int idx = dynamicParam.getIndex();
- // validateDynamicParam is not called by a validator we must call
it ourselves.
- validateDynamicParam(dynamicParam);
-
- // We must check the number of dynamic parameters unless
- // https://issues.apache.org/jira/browse/IGNITE-18653
- // is resolved.
- if (idx < parameters.length) {
- Object param = parameters[idx];
- if (parameters[idx] instanceof Integer) {
- if ((Integer) param < 0) {
- throw newValidationError(n,
IgniteResource.INSTANCE.correctIntegerLimit(nodeName));
- }
+ Object param = parameters[idx];
+ if (parameters[idx] instanceof Integer) {
Review Comment:
```suggestion
if (param instanceof Integer) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
