valepakh commented on code in PR #1812:
URL: https://github.com/apache/ignite-3/pull/1812#discussion_r1143421411


##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/commands/node/metric/NodeMetricDisableCommand.java:
##########
@@ -48,6 +49,7 @@ public Integer call() {
                 .output(spec.commandLine().getOut())
                 .errOutput(spec.commandLine().getErr())
                 .verbose(verbose)
+                .exceptionHandler(new 
ClusterNotInitializedExceptionHandler("Cannot disable metrics", "cluster init"))

Review Comment:
   I would create a ticket and simply extract a factory method which will 
encapsulate the command string.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to