Pochatkin commented on code in PR #1809: URL: https://github.com/apache/ignite-3/pull/1809#discussion_r1144349359
########## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/FileDeployerService.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.deployunit; + +import static java.nio.file.StandardCopyOption.ATOMIC_MOVE; +import static java.nio.file.StandardCopyOption.REPLACE_EXISTING; +import static java.nio.file.StandardOpenOption.CREATE; +import static java.nio.file.StandardOpenOption.SYNC; +import static java.nio.file.StandardOpenOption.TRUNCATE_EXISTING; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.thread.NamedThreadFactory; +import org.apache.ignite.internal.util.IgniteUtils; + +/** + * Service for file deploying on local File System. + */ +public class FileDeployerService { + private static final IgniteLogger LOG = Loggers.forClass(FileDeployerService.class); + + private static final String TMP_SUFFIX = ".tmp"; + + /** + * Folder for units. + */ + private Path unitsFolder; + + private final ExecutorService executor = Executors.newFixedThreadPool(4, new NamedThreadFactory("deployment", LOG)); Review Comment: Threads in a ThreadPool are not allocated immediately, it is the maximum counter of a possible thread. So 4 are chosen as in other thread pools in the AI3 codebase. It can be extracted to a config option later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
