sashapolo commented on code in PR #1807: URL: https://github.com/apache/ignite-3/pull/1807#discussion_r1144382396
########## modules/core/src/main/java/org/apache/ignite/internal/causality/AbstractVersionedValue.java: ########## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.causality; + +import static java.util.concurrent.CompletableFuture.completedFuture; +import static org.apache.ignite.lang.IgniteStringFormatter.format; + +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Map.Entry; +import java.util.NavigableMap; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CompletionException; +import java.util.concurrent.ConcurrentNavigableMap; +import java.util.concurrent.ConcurrentSkipListMap; +import java.util.concurrent.CopyOnWriteArrayList; +import java.util.concurrent.locks.ReadWriteLock; +import java.util.concurrent.locks.ReentrantReadWriteLock; +import java.util.function.Supplier; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.util.Lazy; +import org.jetbrains.annotations.Nullable; + +/** + * Parametrized type to store several versions of a value. + * + * <p>The value can be available through the causality token, which is represented by a {@code long}. + * + * @param <T> Type of real value. + */ +public class AbstractVersionedValue<T> { + private final IgniteLogger log = Loggers.forClass(AbstractVersionedValue.class); Review Comment: I can't =( There's a test, called `ClientArchTest#noStaticIgniteLogger` which fails if there's a static logger in the `core` package. I guess we can simply move `VersionedValue` away from this package (why does Ignite think client need to depend on VersionedValue?), but that's even more changes for this large enough PR ########## modules/core/src/main/java/org/apache/ignite/internal/causality/AbstractVersionedValue.java: ########## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.causality; + +import static java.util.concurrent.CompletableFuture.completedFuture; +import static org.apache.ignite.lang.IgniteStringFormatter.format; + +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Map.Entry; +import java.util.NavigableMap; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CompletionException; +import java.util.concurrent.ConcurrentNavigableMap; +import java.util.concurrent.ConcurrentSkipListMap; +import java.util.concurrent.CopyOnWriteArrayList; +import java.util.concurrent.locks.ReadWriteLock; +import java.util.concurrent.locks.ReentrantReadWriteLock; +import java.util.function.Supplier; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.util.Lazy; +import org.jetbrains.annotations.Nullable; + +/** + * Parametrized type to store several versions of a value. + * + * <p>The value can be available through the causality token, which is represented by a {@code long}. + * + * @param <T> Type of real value. + */ +public class AbstractVersionedValue<T> { + private final IgniteLogger log = Loggers.forClass(AbstractVersionedValue.class); Review Comment: I can't =( There's a test called `ClientArchTest#noStaticIgniteLogger` which fails if there's a static logger in the `core` package. I guess we can simply move `VersionedValue` away from this package (why does Ignite think client need to depend on VersionedValue?), but that's even more changes for this large enough PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
