sashapolo commented on code in PR #1807:
URL: https://github.com/apache/ignite-3/pull/1807#discussion_r1144442521
##########
modules/core/src/main/java/org/apache/ignite/internal/causality/BaseVersionedValue.java:
##########
@@ -40,20 +40,16 @@
import org.jetbrains.annotations.Nullable;
/**
- * Parametrized type to store several versions of a value.
- *
- * <p>The value can be available through the causality token, which is
represented by a {@code long}.
- *
- * @param <T> Type of real value.
+ * Base implementation of a {@code VersionedValue} intended to be used by
other implementations.
*/
-public class AbstractVersionedValue<T> {
- private final IgniteLogger log =
Loggers.forClass(AbstractVersionedValue.class);
+class BaseVersionedValue<T> implements VersionedValue<T> {
+ private final IgniteLogger log =
Loggers.forClass(BaseVersionedValue.class);
Review Comment:
Please see my previous answer to the same question you've asked above:
> I can't =( There's a test called ClientArchTest#noStaticIgniteLogger which
fails if there's a static logger in the core package. I guess we can simply
move VersionedValue away from this package (why does Ignite thin client need to
depend on VersionedValue?), but that's even more changes for this large enough
PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
