sashapolo commented on code in PR #1832:
URL: https://github.com/apache/ignite-3/pull/1832#discussion_r1145960735
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerConfigurationChangesTest.java:
##########
@@ -332,6 +183,8 @@ void testSeveralZoneCreationsUpdatesTriggerKey() throws
Exception {
void testDataNodesNotPropagatedAfterZoneCreation() throws Exception {
keyValueStorage.put(zonesChangeTriggerKey(1).bytes(),
longToBytes(100));
+ clearInvocations(keyValueStorage);
Review Comment:
I think it's better to improve the verification method instead. Currently we
use `verify(keyValueStorage, timeout(1000).times(1)).invoke(any())`, maybe we
can verify actual invocation arguments instead
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerConfigurationChangesTest.java:
##########
@@ -115,178 +98,47 @@ public void setUp() {
DistributionZonesConfiguration zonesConfiguration =
clusterCfgMgr.configurationRegistry()
.getConfiguration(DistributionZonesConfiguration.KEY);
- MetaStorageManager metaStorageManager = mock(MetaStorageManager.class);
-
-
when(metaStorageManager.appliedRevision(any())).thenReturn(completedFuture(0L));
+ vaultMgr = new VaultManager(new InMemoryVaultService());
LogicalTopologyService logicalTopologyService =
mock(LogicalTopologyService.class);
+ doNothing().when(logicalTopologyService).addEventListener(any());
Review Comment:
Why do you need this stubbing? It's already a mock and will do nothing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
