sashapolo commented on code in PR #1854:
URL: https://github.com/apache/ignite-3/pull/1854#discussion_r1151528855
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerTest.java:
##########
@@ -734,21 +820,21 @@ private TableManager
createTableManager(CompletableFuture<TableManager> tblManag
) {
@Override
protected MvTableStorage createTableStorage(TableConfiguration
tableCfg, TablesConfiguration tablesCfg) {
- return Mockito.spy(super.createTableStorage(tableCfg,
tablesCfg));
+ mvTableStorage = spy(super.createTableStorage(tableCfg,
tablesCfg));
+
+ return mvTableStorage;
}
@Override
protected TxStateTableStorage
createTxStateTableStorage(TableConfiguration tableCfg) {
- return Mockito.spy(super.createTxStateTableStorage(tableCfg));
+ txStateTableStorage =
spy(super.createTxStateTableStorage(tableCfg));
+
+ return txStateTableStorage;
}
};
sm.start();
- if (!waitingSqlSchema) {
Review Comment:
Most likely this is a remnant of a refactoring (take a look at [this
commit](https://github.com/apache/ignite-3/commit/dac5eea8a7e068e70759f21dc180b595c9b7038d#diff-55a0f3352995b95631fd08274bac04cc06655335ff88eeef8ca362bf88869ff2R773).
The listener is a no-op now, unless I'm missing something. And the tests pass
without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
