alievmirza commented on code in PR #1840:
URL: https://github.com/apache/ignite-3/pull/1840#discussion_r1151812985
##########
modules/api/src/main/java/org/apache/ignite/lang/IgniteException.java:
##########
@@ -32,27 +32,23 @@
import org.jetbrains.annotations.Nullable;
/**
- * General Ignite exception. This exception is used to indicate any error
condition within the node.
+ * General Ignite exception. Used to indicate any error condition within a
node.
*/
public class IgniteException extends RuntimeException {
- /** Serial version uid. */
+ /** Serial version UID. */
private static final long serialVersionUID = 0L;
/** Name of the error group. */
private final String groupName;
/**
- * Error code which contains information about error group and code, where
code is unique within the group.
- * The structure of a code is shown in the following diagram:
- * +------------+--------------+
- * | 16 bits | 16 bits |
- * +------------+--------------+
- * | Group Code | Error Code |
+ * Error code that contains information about the error group and code,
where the code is unique within the group. The code structure is
+ * as follows: +------------+--------------+ | 16 bits | 16 bits |
+------------+--------------+ | Group Code | Error Code |
Review Comment:
formatting
##########
modules/api/src/main/java/org/apache/ignite/lang/TableAlreadyExistsException.java:
##########
@@ -17,31 +17,29 @@
package org.apache.ignite.lang;
-import static org.apache.ignite.internal.util.IgniteNameUtils.canonicalName;
import static
org.apache.ignite.lang.ErrorGroups.Table.TABLE_ALREADY_EXISTS_ERR;
import java.util.UUID;
/**
- * This exception is thrown when a new table failed to be created, because a
table with same name already exists.
+ * This exception is thrown when a table creation has failed because a table
with the specified name already existed.
*/
public class TableAlreadyExistsException extends IgniteException {
/**
- * Create a new exception with given table name.
+ * Creates an exception with the given table name.
*
- * @param schemaName Schema name.
- * @param tableName Table name.
+ * @param name Table name.
*/
- public TableAlreadyExistsException(String schemaName, String tableName) {
- super(TABLE_ALREADY_EXISTS_ERR, "Table already exists [name=" +
canonicalName(schemaName, tableName) + ']');
+ public TableAlreadyExistsException(String name) {
Review Comment:
This is a mistake that leads to the compilation error
##########
modules/api/src/main/java/org/apache/ignite/IgnitionManager.java:
##########
@@ -40,34 +40,32 @@ public class IgnitionManager {
private static Ignition ignition;
/**
- * Starts an Ignite node with an optional bootstrap configuration from an
input stream with HOCON configs.
+ * Starts an Ignite node with an optional bootstrap configuration from an
input stream with a HOCON configuration file.
*
- * <p>When this method returns, the node is partially started and ready to
accept the init command (that is, its
+ * <p>When this method returns, the node is partially started, and is
ready to accept the init command (that is, its
* REST endpoint is functional).
*
* @param nodeName Name of the node. Must not be {@code null}.
- * @param configStr Optional node configuration.
- * Following rules are used for applying the configuration properties:
+ * @param config Optional node configuration based on
+ * {@link
org.apache.ignite.configuration.schemas.network.NetworkConfigurationSchema}.
+ * The following rules are used for applying the configuration
properties:
* <ol>
- * <li>Specified property overrides existing one or just applies
itself if it wasn't
- * previously specified.</li>
- * <li>All non-specified properties either use previous value or
use default one from
- * corresponding configuration schema.</li>
+ * <li>Specified property overrides the existing one, if any.</li>
+ * <li>All non-specified properties use either the previous value
or use default one from
+ * the corresponding configuration schema.</li>
* </ol>
- * So that, in case of initial node start (first start ever)
specified configuration, supplemented
- * with defaults, is used. If no configuration was provided defaults
are used for all
- * configuration properties. In case of node restart, specified
properties override existing
- * ones, non specified properties that also weren't specified
previously use default values.
- * Please pay attention that previously specified properties are
searched in the
- * {@code workDir} specified by the user.
+ * Therefore, for the initial node start (first start ever), the
specified configuration augmented
+ * with defaults, is used. If no configuration is provided, defaults
are used for all
+ * configuration properties. For a node restart, the specified
properties override existing
+ * ones, and the non-specified properties that hadn't been specified
previously use the default values.
+ * The previously specified property values are retrieved from the
user-specified {@code workDir}.
*
- * @param workDir Work directory for the started node. Must not be {@code
null}.
- * @return Completable future that resolves into an Ignite node after all
components are started and the cluster initialization is
+ * @param workDir Work directory for the node. Must not be {@code null}.
+ * @return CompletableFuture that resolves to an Ignite node after all
components are started and the cluster initialization is
* complete.
- * @throws IgniteException If error occurs while reading node
configuration.
+ * @throws IgniteException If an error occurs while reading the node
configuration.
*/
// TODO IGNITE-14580 Add exception handling logic to IgnitionProcessor.
- //TODO: Move IGNITE-18778
Review Comment:
Why did you remove this todo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
